Skip to content
This repository has been archived by the owner on Jun 6, 2018. It is now read-only.

Docker best practice #89

Closed
wants to merge 3 commits into from
Closed

Docker best practice #89

wants to merge 3 commits into from

Conversation

guessi
Copy link

@guessi guessi commented Mar 9, 2018

hope you could merge this MR for better test environment

Improved Items:

  • Bump Ubuntu base image (14.04.2 -> 14.04 [latest])
  • Add Alpine 3.7 support
  • Minimize Docker image layer
  • Try not to hard-code minor version (alpine)

- Bump Ubuntu base from 14.04.2 to 14.04 (aka. latest)
- Reduce package installation
- Minimized Docker layer
*note*

alpine33 does not support '~='
@kunagpal
Copy link
Contributor

kunagpal commented Mar 11, 2018

@guessi Thanks for creating this pull request, but this newman-docker specific repository is being deprecated in favour of https://github.com/postmanlabs/newman via postmanlabs/newman#1397 to allow automated pushes to Docker Hub alongwith regular npm publish actions. While your changes have been noted, most of them are already being ported to the core Newman repository.

Also, directly bumping the Alpine image version to 3.7 would lead to potential cofusion. We do plan to move to Alpine 3.7 and drop support for v3.3 (due to the Node version restriction), this would happen with a major (breaking change) release of Newman in the future.

@kunagpal kunagpal closed this Mar 11, 2018
@guessi
Copy link
Author

guessi commented Mar 12, 2018

@kunagpal Oops... I'm not aware there's an existed PR in another repository, please feel free to let me know if there's anything I can help :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants